Fixes bug in UndoManager where entering text while redo stack is not emp... #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty causes error. The error is caught in record and therefore the undo and redo stacks are cleared. The error specifically occurs because the 'oldDelta' does not match the editor state, and more specifically when that means the oldDelta lengths are incorrect. This change causes the oldDelta to be updated whenever the UndoManager has an undo or redo triggered.
| @@ -95,6 +95,8 @@ class UndoManager | |||
| @emittedDelta = null | |||
| index = this._getLastChangeIndex(change[source]) | |||
| @quill.setSelection(index, index) | |||
| # store updated delta | |||
|
Thank you for the PR. Can you fix the two issues I commented about and I can merge? |
…tance variable references (@).
|
Updated! |
|
Great thanks! |
jhchen
added a commit
that referenced
this pull request
Oct 20, 2014
Fixes bug in UndoManager where entering text while redo stack is not empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ty causes error. The error is caught in record and therefore the undo and redo stacks are cleared. The error specifically occurs because the 'oldDelta' does not match the editor state, and more specifically when that means the oldDelta lengths are incorrect. This change causes the oldDelta to be updated whenever the UndoManager has an undo or redo triggered. Related to #229