fix for changing links in tooltip #113 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,7 @@ class LinkTooltip extends Tooltip | |||
| return unless range? and range.isCollapsed() | |||
| anchor = this._findAnchor(range) | |||
| if anchor | |||
| @range = range | |||
There was a problem hiding this comment.
This is actually unnecessary. The Tooltip class will save the range before the tooltip showing.
|
Great thanks! I added some comments to the file. If you could fix those issues I can merge into develop. |
|
Requested changes complete. |
| @@ -54,7 +54,11 @@ class LinkTooltip extends Tooltip | |||
|
|
|||
| saveLink: -> | |||
| url = this._normalizeURL(@textbox.value) | |||
| @quill.formatText(@range, 'link', url, 'user') if @range? | |||
| if @range? and @range.isCollapsed() | |||
There was a problem hiding this comment.
Sry I meant the if range should be its own followed by another if else block so:
if @range?
if @range.isCollapsed()
# Anchor
else
# formatText This is because formatText needs range to be defined as well.
|
Fix made. |
| anchor = this._findAnchor(@range) | ||
| anchor.href = url if anchor? | ||
| else | ||
| @quill.formatText(@range, 'link', url, 'user') if @range? |
There was a problem hiding this comment.
One last thing: can you get rid of the if range at the end? It's already inside a check for range being defined
jhchen
added a commit
that referenced
this pull request
May 31, 2014
fix for changing links in tooltip closes #113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cross browser bug in #113. Allows links to be changed using the tooltip.