Fix embed inherits formats unexpectedly

slab · Jun 1, 2023 · 665d30c · 665d30c
1 parent 663e9bd
commit 665d30c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/core/editor.ts b/core/editor.ts
@@ -62,6 +62,9 @@ class Editor {
             ) {
               isImplicitNewlineAppended = true;
             }
+            const [leaf] = this.scroll.leaf(index);
+            const formats = merge({}, bubbleFormats(leaf));
+            attributes = AttributeMap.diff(formats, attributes) || {};
           } else if (index > 0) {
             // @ts-expect-error
             const [leaf, offset] = this.scroll.descendant(LeafBlot, index - 1);

diff --git a/test/unit/core/editor.js b/test/unit/core/editor.js
@@ -517,6 +517,16 @@ describe('Editor', function () {
       );
     });
 
+    it('insert inline embed to the middle of formatted content', function () {
+      const editor = this.initialize(Editor, '<p><strong>0123</strong></p>');
+      editor.applyDelta(
+        new Delta().retain(2).insert({ image: '/assets/favicon.png' }),
+      );
+      expect(this.container).toEqualHTML(
+        '<p><strong>01</strong><img src="/assets/favicon.png"><strong>23</strong></p>',
+      );
+    });
+
     it('insert block embed with delete before block embed', function () {
       const editor = this.initialize(
         Editor,