chore: typos & refine comments #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzhseh
reviewed
Mar 21, 2024
ben1009
changed the title
skyzh
approved these changes
Mar 24, 2024
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 25, 2024
* typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 25, 2024
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 25, 2024
* chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
May 29, 2024
* chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
May 29, 2024
* fix test panic Signed-off-by: Alex Chi <iskyzh@gmail.com> * chore: merge upstream (#35) * chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com> --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Jul 9, 2024
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Jul 9, 2024
* chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Jul 9, 2024
* fix test panic Signed-off-by: Alex Chi <iskyzh@gmail.com> * chore: merge upstream (#35) * chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com> --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 10, 2025
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 10, 2025
* chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 10, 2025
* fix test panic Signed-off-by: Alex Chi <iskyzh@gmail.com> * chore: merge upstream (#35) * chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com> --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 10, 2025
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 10, 2025
* chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
ben1009
added a commit
to ben1009/mini-lsm
that referenced
this pull request
Mar 10, 2025
* fix test panic Signed-off-by: Alex Chi <iskyzh@gmail.com> * chore: merge upstream (#35) * chore: typos & refine comments (skyzh#65) * typo in week2-01-compaction.md * chroe: typos & add comments * chore: more typos * Update week2-01-compaction.md --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> * Fix typos in W3D5 writeup and code (skyzh#67) * Fix minor mistake in W3D6 writeup (skyzh#69) --------- Co-authored-by: Alex Chi Z <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com> --------- Signed-off-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Alex Chi <iskyzh@gmail.com> Co-authored-by: Yue Yin <41224888+yyin-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typos -w, suggest add typos-cli to gha