Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove module dependencies #392

Merged
merged 3 commits into from
Jan 20, 2021
Merged

remove module dependencies #392

merged 3 commits into from
Jan 20, 2021

Conversation

ntessore
Copy link
Member

Remove dependencies from master that belong to stripped modules (#389).

@ntessore ntessore added this to the Version 0.4 milestone Jan 20, 2021
@ntessore ntessore requested a review from rrjbca January 20, 2021 10:39
philipp128
philipp128 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@philipp128 philipp128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I can see it only contains the dependencies necessary for the galaxy module as supposed to do.

@rrjbca rrjbca merged commit 225de6f into skypyproject:master Jan 20, 2021
@ntessore ntessore deleted the module-deps branch January 20, 2021 13:19
rrjbca pushed a commit that referenced this pull request Feb 25, 2021
@rrjbca
Revert "remove module dependencies (#392)"
5c62061 
This reverts commit 225de6f.
rrjbca pushed a commit that referenced this pull request Feb 26, 2021
@rrjbca
Revert "remove module dependencies (#392)"
4db14a8 
This reverts commit 225de6f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp128 philipp128 philipp128 approved these changes

@rrjbca rrjbca rrjbca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ntessore @philipp128 @rrjbca