-
-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix C4003 NOMINMAX bug #531
Conversation
Please, don't update the single include file. It's generated automatically. |
I've removed the changes to the single include file.
I did a search for "min" in A search for |
There is a script to generate the single include file. I update it regularly (well, more or less apparently 😄). |
Is the script part of the repo? If it is, where is it located? |
Yup, |
Closes #530
Closes #96
This fixes the
std::min
andstd::max
functions being parsed as macros when<windows.h>
is included and#define NOMINMAX
is neither present nor included before all other headers.Note: There is a use of
std::max
in the single-include header that does not appear anywhere else in the separated-out code. I could not find where the single-include header is generated to see where it's coming from.