Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast removal of S3 Storage buckets with 10k-1 million objects #893

Merged
merged 552 commits into from
Jun 6, 2022
Merged
Changes from 1 commit
Commits
Show all changes
552 commits
Select commit Hold shift + click to select a range
61020db
Fixes for document and README (#360)
Michaelvll Feb 18, 2022
f212f1e
Update links in documentation and README (#366)
gmittal Feb 18, 2022
62fae46
Improve adaptors (#359)
suquark Feb 18, 2022
849e753
Limit grpcio version for #369 (#370)
Michaelvll Feb 18, 2022
232fc65
Remove typo from README (#371)
gmittal Feb 18, 2022
e26ef9c
Fix Azure credential errors on AWS (#372)
suquark Feb 18, 2022
fd57445
fix typo (#376)
gmittal Feb 18, 2022
47e264d
Restore README to the original place (#374)
suquark Feb 19, 2022
edb7f10
Support 'name:cnt' accelerators spec in YAML (#396)
concretevitamin Feb 21, 2022
99344b1
README example: change `K80:4` to `V100:1` (#399)
concretevitamin Feb 21, 2022
6276b0f
Workdir Docs (#405)
michaelzhiluo Feb 21, 2022
4486851
Fix `check_local_gpus` (#411)
WoosukKwon Feb 22, 2022
8d17229
Sky Storage CLI (#338)
michaelzhiluo Feb 22, 2022
d19a6fd
Sky Storage CLI - Polishing (#414)
michaelzhiluo Feb 23, 2022
53847a6
Decouple `ray up` and user's file_mounts / setup (#407)
Michaelvll Feb 23, 2022
3f43c99
Minor fix (#419)
WoosukKwon Feb 23, 2022
2d033aa
Revert to using file_mounts for object mounting (#412)
romilbhardwaj Feb 23, 2022
24a49c8
[docker] Quick fix to remove already-dead docker containers from `sky…
WoosukKwon Feb 23, 2022
63eff9e
Update documentation with provisioning quickstart (#415)
gmittal Feb 23, 2022
a8141ab
Add improved progress meters + log suppression (#425)
gmittal Feb 23, 2022
d71e2d2
Add cross-cloud failover to docs. (#433)
concretevitamin Feb 24, 2022
6249847
Add document for `bash script.sh` cannot do `conda activate` problem …
Michaelvll Feb 24, 2022
f7df7a8
Remove `-i` for `bash user_script.sh` (#436)
Michaelvll Feb 24, 2022
b45f04c
Fix Azure key generation (#429)
romilbhardwaj Feb 24, 2022
b1d7431
[Storage/File-Mounting] Fix Symlink Issue + Fix File Mounting (#431)
michaelzhiluo Feb 24, 2022
e5b5847
Fix error message when azure-cli is not installed (#424)
romilbhardwaj Feb 24, 2022
bfd93f9
Fixing Relative Directory for Workdir and File Mounts (`~/sky_workdir…
michaelzhiluo Feb 24, 2022
93e036e
Fix gitignore for rsync (#448)
Michaelvll Feb 25, 2022
0d86924
Remove tracebacks for exceptions to improve UX (#441)
Michaelvll Feb 25, 2022
e3cd181
Fix delayed logs of `sky logs` locally vs `tail -f` remotely (#454)
Michaelvll Feb 25, 2022
c9ae7d8
[Storage/File Mount] Check `workdir` and Filemount `src` Size (#440)
michaelzhiluo Feb 25, 2022
6f05b41
Fix assertion on Azure's A100/V100 and fuzzy resource search (#368)
infwinston Feb 26, 2022
78326eb
Fix using_file_mounts (#465)
Michaelvll Feb 28, 2022
03ef9fa
Improve docs / logging messages. (#466)
concretevitamin Mar 1, 2022
c7dfc42
Fix `sky logs` with interactive ssh causing job status wrongly set if…
Michaelvll Mar 1, 2022
9609d43
Pricing information for `sky show-gpus` (#472)
gmittal Mar 1, 2022
4e52ce5
[Azure] Downgrade the image version for K80 instances (#460)
WoosukKwon Mar 2, 2022
47f25b7
Centralize sky_logs, polish logging, and update `sky start` documenta…
gmittal Mar 2, 2022
824a23c
Gcloud Authentication Bug Fix (#437)
michaelzhiluo Mar 2, 2022
462e8ab
fix tail_logs (#476)
Michaelvll Mar 3, 2022
b5426a3
Mention .gitignore for workdir sync in docs (#470)
gmittal Mar 3, 2022
10dcb4d
Suppress rsync output (#459)
Michaelvll Mar 3, 2022
1a0bcc1
Small fix for the cloud_stores cli installation (#477)
Michaelvll Mar 3, 2022
fd19207
Revert "Small fix for the cloud_stores cli installation" (#479)
Michaelvll Mar 3, 2022
4936950
Fix hint for multiple instance candidates (#475)
infwinston Mar 3, 2022
c2fa604
Add confirmation prompt for cluster management operations (#471)
gmittal Mar 3, 2022
e204cf4
Minor fix for sky launch --gpus tpu-* (#481)
WoosukKwon Mar 4, 2022
909f4bd
Docs: polish installation & quickstart (#478)
concretevitamin Mar 4, 2022
6cc62aa
Fix prompting for launching on a stopped cluster. (#487)
concretevitamin Mar 4, 2022
9ab2a41
Fix credential mounting (#483)
Michaelvll Mar 4, 2022
32eff5a
Parallel Setup + Filemounting (#458)
michaelzhiluo Mar 5, 2022
f5f2283
Fix Azure Promo Instances (#485)
infwinston Mar 6, 2022
1604bf1
Polish workdir/file_mounts validation and logging. (#495)
concretevitamin Mar 7, 2022
1e4e738
Docs: polish quickstart, interactive-nodes (#491)
concretevitamin Mar 7, 2022
446121d
Fix rsync_exclude for gcp credential file_mounts (#496)
Michaelvll Mar 7, 2022
473acfc
Fix: return when there are no matched clusters (#500)
suquark Mar 7, 2022
d4b0c0b
Make GPU/TPU names case-insensitive (#463)
WoosukKwon Mar 8, 2022
bfe0f4d
task.py: validate workdir by expanding full path (#505)
concretevitamin Mar 8, 2022
4d63f4d
Revamp docs (getting started; use cases). (#503)
concretevitamin Mar 8, 2022
b99ae42
Fix ulimit for provision (#512)
Michaelvll Mar 9, 2022
9df2b67
README: remove quick example. (#521)
concretevitamin Mar 10, 2022
0a40e39
[docker] Change remote working directory into `/sky_workdir` (#497)
WoosukKwon Mar 10, 2022
2195f05
Fix Azure resource leak (#501)
suquark Mar 10, 2022
9ba9fd2
Timeout for multi-node launching (#504)
Michaelvll Mar 10, 2022
26f68a4
[docker] Fix a bug in updating image list (#525)
WoosukKwon Mar 10, 2022
87f9305
Fix help str for aws/azure credential check (#532)
Michaelvll Mar 10, 2022
7237f19
Fix TPU logging when failed to launch (#526)
Michaelvll Mar 10, 2022
d344a74
Fix aws apt install (#529)
Michaelvll Mar 10, 2022
f2be0c9
Docs: more polishing. (#523)
concretevitamin Mar 10, 2022
d053691
Add copy button to code blocks in documentation (#534)
gmittal Mar 10, 2022
17030d6
Fix non-interactive SSH commands in task setup (#533)
gmittal Mar 10, 2022
d277420
Simple SSH into Multi-node Workers from Local (#469)
michaelzhiluo Mar 11, 2022
07bb1dd
Docs: significantly de-ink quickstart (#539)
concretevitamin Mar 12, 2022
f0d416d
Revert "Simple SSH into Multi-node Workers from Local (#469)" (#552)
concretevitamin Mar 12, 2022
5a30f05
Fix the dpkg lock for apt install (#554)
Michaelvll Mar 13, 2022
5dd9716
Added FileLock on cluster launch and teardown (#510)
mraheja Mar 14, 2022
edf6c4b
Polish quickstart. (#560)
concretevitamin Mar 14, 2022
e340e11
Fix the lock logic for provision (#562)
Michaelvll Mar 14, 2022
aae04e3
Improve instance hints by moving messages to optimizer & speedup sky …
infwinston Mar 14, 2022
c6955a4
AWS Ray Setup - Alias Python=Python3 if Alias does not exist (#558)
michaelzhiluo Mar 15, 2022
7efb0d3
Improve optimizer message (#571)
WoosukKwon Mar 15, 2022
06844e6
Fix sky behavior when weird behavior of `ray status` for GCP occur (#…
Michaelvll Mar 15, 2022
fb92cb5
Allowed forced teardown when called within locked code (#582)
mraheja Mar 15, 2022
005a6b2
Set $TPU_NAME during provisioning (#587)
gmittal Mar 15, 2022
53fdaa5
Sky Installation for Mac <1.15 Warnings + Doc (#569)
michaelzhiluo Mar 15, 2022
b14d642
Fix prompt, add fallback retry for INIT cluster (#559)
Michaelvll Mar 15, 2022
dae96f5
Fix CLI not installed for `sky check` (#592)
Michaelvll Mar 16, 2022
8e3f4a6
Upgrade aws ami and add back us-west-1 (#564)
Michaelvll Mar 16, 2022
8a28dc4
Fix order of setup (#593)
Michaelvll Mar 16, 2022
bd3584a
unique cluster name list for sky down (#596)
Michaelvll Mar 16, 2022
12b9ded
SSH into Worker Nodes from Local (#557)
michaelzhiluo Mar 17, 2022
713a0c3
Glob cluster name for sky down (#598)
Michaelvll Mar 17, 2022
f7f4e38
Fix cuda version for tf training (#603)
Michaelvll Mar 17, 2022
0e29336
Add `conda init` to AWS setup commands (#604)
WoosukKwon Mar 17, 2022
b941e6f
Created and handled teardown success bool (#581)
mraheja Mar 17, 2022
856bd86
Add instructions in document for quota increase (#588)
infwinston Mar 17, 2022
b0438c4
Add fine-grained logging during provisioning (#565)
gmittal Mar 18, 2022
64fcdf7
Remove job_submit.log & clarify `sky exec --help` (#611)
concretevitamin Mar 19, 2022
647c461
Parallel runner of smoke tests. (#584)
concretevitamin Mar 19, 2022
4bc8598
Update GCP image for OS consistency and fix GCP's spot CPU (#614)
infwinston Mar 19, 2022
f9b1d84
Optimize the `sky job queue` when large amount of jobs running (#616)
Michaelvll Mar 19, 2022
e02aa8b
apt update for aws (#620)
Michaelvll Mar 19, 2022
1f7a7bc
[Docker] Install sudo in docker (#595)
romilbhardwaj Mar 22, 2022
26522be
Refactor JobLibCodeGen and fix stale job for restarting cluster (#621)
Michaelvll Mar 23, 2022
873a99d
Make azure-start-stop use 1 node to speed up tests. (#619)
concretevitamin Mar 23, 2022
ded4957
Fix hint msg (#634)
infwinston Mar 24, 2022
c64cb05
Make test cluster names unique for (user, mac address). (#639)
concretevitamin Mar 24, 2022
c466702
Roll back to debian-based image (#636)
infwinston Mar 24, 2022
0a4a943
Fix the second `sky launch` assertion and ray job status for failed j…
Michaelvll Mar 24, 2022
58917a0
Add disk_size to YAML ref; other minor cleanups. (#643)
concretevitamin Mar 25, 2022
a0982a1
Add a skylet daemon and fix job status problem (#623)
Michaelvll Mar 25, 2022
c210da5
Align underscore / dash for num-nodes cli option (#654)
Michaelvll Mar 27, 2022
8083708
Optimize backend_utils.get_node_ips(), esp. for Azure. (#630)
concretevitamin Mar 28, 2022
12d6f75
Minor touches on docs + improve install UX (#660)
concretevitamin Mar 28, 2022
6fb7a10
Refactor type_checking (#655)
Michaelvll Mar 28, 2022
39a03a7
Build Sky local wheel in a unique tempdir per launch. (#657)
concretevitamin Mar 29, 2022
3451dd2
Tear down head node even for HEAD_FAILED. (#661)
concretevitamin Mar 29, 2022
5189b50
Added sky down --purge (#635)
mraheja Mar 29, 2022
904bdb0
Parallel sky down (#659)
Michaelvll Mar 29, 2022
f2225b1
rsync: --filter on .git/info/exclude (#652)
concretevitamin Mar 30, 2022
71ee5b7
Fix repeating IP Address bug (#663)
michaelzhiluo Mar 30, 2022
459bf95
Fix output for parallel down (#666)
Michaelvll Mar 30, 2022
569a09e
Auto stop for cluster (#653)
Michaelvll Mar 31, 2022
0e27dbc
Refactor DAG Optimizer (#628)
WoosukKwon Mar 31, 2022
1d7bd91
Improve UX for autostopping (#676)
Michaelvll Apr 1, 2022
7045642
Improve logging in error conditions & update auto-stop.rst (#675)
concretevitamin Apr 1, 2022
7f8a571
Add GLOB for sky queue (#678)
Michaelvll Apr 1, 2022
42202ed
Added price to sky status (#561)
mraheja Apr 1, 2022
1d5cb7c
Add line processor abstraction and fix gitignored path size (#615)
gmittal Apr 1, 2022
4517202
ILP-based DAG Optimizer (#637)
WoosukKwon Apr 2, 2022
795b872
Touches on docs. (#684)
concretevitamin Apr 3, 2022
de5ac9b
Storage mounting (#658)
romilbhardwaj Apr 3, 2022
5c449fc
Update artifact syncing docs (#689)
romilbhardwaj Apr 3, 2022
f357dd4
Docker example and fix goofys-docker mounting (#686)
Michaelvll Apr 3, 2022
c9cb3a1
Add faq.rst; move CLI section to the bottom. (#690)
concretevitamin Apr 3, 2022
2c294a3
Speedup ci/cd with parallelism (#693)
Michaelvll Apr 4, 2022
bb8c410
Verify acclerators and support float for inline GPU requirement V100:…
Michaelvll Apr 4, 2022
da91e6c
Storage Subdirectory Fix (#709)
michaelzhiluo Apr 5, 2022
f337f64
Minor: suggest using a conda env when installing Sky. (#710)
concretevitamin Apr 5, 2022
5d6b18a
Fix optimizer messages (#711)
WoosukKwon Apr 5, 2022
1eab947
Prompt Before Storage Initialization for `sky launch` (#701)
michaelzhiluo Apr 5, 2022
78a3986
Fix sky start when cluster is autostopped without`sky status --refres…
Michaelvll Apr 5, 2022
93f0040
Fix the hardcoded gcp project id (#692)
Michaelvll Apr 5, 2022
e1161ef
Fix azure subscription id (#720)
Michaelvll Apr 6, 2022
e3fa8ec
Skip cloud when instance type is provided and make resources immutabl…
Michaelvll Apr 6, 2022
418d12d
Instruction for file_mounts trick (#694)
Michaelvll Apr 6, 2022
3d1f6e9
Specify region in resources (#722)
Michaelvll Apr 7, 2022
564f70b
Ship AWS cloud provider (#725)
suquark Apr 8, 2022
1aa27de
Goofys memory optimizations (#726)
romilbhardwaj Apr 9, 2022
3ce1590
Make sky exec submit jobs for inline commands; guard Azure disabled s…
concretevitamin Apr 9, 2022
ab6a002
Add job duration and resources (#729)
Michaelvll Apr 10, 2022
db45e70
UX improvement for sky stop and down (#734)
Michaelvll Apr 12, 2022
f29af06
Fix AWS multi-node failure (#736)
suquark Apr 12, 2022
772192b
Fix TPU naming issue (#737)
gmittal Apr 12, 2022
641205d
Format duration for jobs (#744)
Michaelvll Apr 15, 2022
f66e41b
Shared default security group for AWS (#731)
suquark Apr 15, 2022
280ad35
Add TPU pods (#739)
infwinston Apr 15, 2022
3c327b3
Fix small nits in code (#748)
suquark Apr 16, 2022
8cbf57f
Fix race condition for skylet daemon (#747)
Michaelvll Apr 16, 2022
d34e365
Fix the setup progress bar and conda confirmation message (#746)
Michaelvll Apr 19, 2022
5fdc78c
Get rid of cloud dependencies in the config template (#749)
suquark Apr 19, 2022
8a9ac6f
Add W&B setup in FAQ (#751)
WoosukKwon Apr 20, 2022
f545067
Small refactor of CLI and cloud (#752)
Michaelvll Apr 21, 2022
9ab8ece
Fix descendant processes termination for sky cancel (#758)
Michaelvll Apr 23, 2022
1e971b4
Minor logging fix. (#760)
concretevitamin Apr 23, 2022
4fea76f
Add test_cancel() to smoke. (#761)
concretevitamin Apr 23, 2022
92b0c87
Support glob patterns for jobs for `sky logs -s` (#685)
mraheja Apr 24, 2022
2a82535
Minor: update README (#762)
concretevitamin Apr 24, 2022
3a10b72
Reformat `sky status` codepath and minor fixes (#721)
mraheja Apr 25, 2022
8925f7a
A quick fix for CLOUD_REGISTRY.from_str for None (#766)
Michaelvll Apr 27, 2022
53d437c
Fix killing the whole session problem (#767)
Michaelvll Apr 27, 2022
6a369f4
Add doc for gcloud 400 error (#764)
infwinston Apr 27, 2022
28c5e5d
Fix sky cancel (#770)
infwinston Apr 28, 2022
57cd3e1
Fix format all (#768)
suquark Apr 29, 2022
bf91e1b
Managed spot (alpha) (#759)
Michaelvll Apr 29, 2022
1fd81ef
Reuse sky wheels for efficiency (#769)
suquark Apr 29, 2022
08077a8
Add spot status --all, fix default value for use_spot and fix GCP dep…
Michaelvll Apr 29, 2022
ab6350f
Fix security group mismatch issue with autostop (#780)
suquark Apr 30, 2022
8602130
Spot cancel -a and spot status --refresh (#776)
Michaelvll May 1, 2022
948d1b4
Disallow long cluster names. (#781)
concretevitamin May 2, 2022
625d6ab
Remove storage_demo.yaml from smoke tests (#782)
romilbhardwaj May 2, 2022
e876c95
Fix smoke test for accelerators (#785)
Michaelvll May 2, 2022
d252e55
Fixing some errors encountered in smoke tests. (#787)
concretevitamin May 3, 2022
2f0ff17
remove filter in aws command and fix spot failover (#789)
infwinston May 3, 2022
881e6cc
Add status check when cancelling managed spot job and disable ambiguo…
Michaelvll May 3, 2022
3efcef0
Fix storage tests failing with parallel runners (#794)
romilbhardwaj May 3, 2022
036141d
File mounts for managed spot jobs (#788)
Michaelvll May 5, 2022
a27732f
Minor: logging polishes. (#804)
concretevitamin May 5, 2022
7f2b133
Fix copy_mount_str (#806)
Michaelvll May 5, 2022
94d86a2
Fix TPU resource leak (#797)
infwinston May 5, 2022
c15ff05
Add BERT and Resnet spot examples (#792)
infwinston May 6, 2022
6138a3c
Add env option for sky launch and exec (#803)
Michaelvll May 6, 2022
cb21e1f
Fix race condition between job set_state and update_status (#805)
Michaelvll May 6, 2022
99fbd3f
Fix bert qa example (#808)
infwinston May 7, 2022
3490ba8
Fix `tpu_rc` unassigned bug; minor fix on task resources_str. (#810)
concretevitamin May 7, 2022
da93717
Support streaming logs from the spot cluster through spot controller …
Michaelvll May 8, 2022
b9ffb3c
Fix a rare failure of wheels build (#809)
suquark May 8, 2022
87060f3
Avoid ray messing up terminal with misaligned outputs (#813)
Michaelvll May 9, 2022
db42405
Install ray only when it is not installed on the remote instance (#811)
Michaelvll May 9, 2022
62afa52
Fix autoscaler benign assertion by patching (#815)
concretevitamin May 10, 2022
3db7d73
Make wheel paths stable to avoid disrupting certain running Sky tasks…
concretevitamin May 10, 2022
120541d
Make ray_patches real patch files (#821)
concretevitamin May 10, 2022
24aaac7
Fix GCP project ID (#824)
infwinston May 11, 2022
82ef2cc
Move the STARTED column to sky spot status -a (#823)
Michaelvll May 11, 2022
b33da49
Fix signal handling with stdin=NULL (#818)
Michaelvll May 11, 2022
e5d18e0
[Breaks existing AWS clusters!] Change AWS security group name (#826)
concretevitamin May 11, 2022
96caf32
Remove undesired autoscaling (#830)
Michaelvll May 12, 2022
0f8705b
Use real job time in the `sky spot status` (#827)
Michaelvll May 12, 2022
2a9ac1c
Fix compatibility of the patch (#838)
Michaelvll May 14, 2022
3d369ee
Spot controller UX improvements (#839)
concretevitamin May 14, 2022
46a7221
UX for job duration (#840)
Michaelvll May 14, 2022
a10a304
fix None problem (#842)
gmittal May 14, 2022
01c1aae
Docs for spot jobs (#844)
Michaelvll May 16, 2022
0bc2b06
Add cli doc for spot (#846)
Michaelvll May 16, 2022
3710ce5
Fix spot price for GCP (#847)
Michaelvll May 16, 2022
0a3d4e5
Fix sky cancel for on-prem mode (#775)
infwinston May 17, 2022
4e06011
Fix subprocess daemon bug (#850)
infwinston May 18, 2022
6140a89
Fix A100 provisioning on GCP (#829)
infwinston May 19, 2022
2f2eaac
Cluster status meaning in `sky status --help` (#843)
gmittal May 21, 2022
a9b6649
Better optimizer plan logs (#860)
Michaelvll May 23, 2022
5d7cf1f
Fix docs build warnings and remove code search (#834)
gmittal May 23, 2022
697a1e7
Add Jupyter notebook tutorial to docs (#841)
gmittal May 25, 2022
8a8d00f
Fix sqlite3 rename problem with older version (#868)
Michaelvll May 27, 2022
c605159
Fix on-demand price (#866)
Michaelvll May 31, 2022
2ac9055
Enable timeline recording for Sky (#833)
suquark May 31, 2022
47735f4
Fix Ray autoscaler's failure of gpu auto detection (#848)
infwinston May 31, 2022
9d7fa8a
Add retry-until-up feature for launch and start (#863)
Michaelvll Jun 1, 2022
7193f0a
Sky docker image (#869)
romilbhardwaj Jun 1, 2022
d43a0d7
Upload only necessary credentials and add gpu to cpu mapping for GCP …
Michaelvll Jun 1, 2022
6b10763
Fix default image (#874)
romilbhardwaj Jun 1, 2022
913804e
add check before ping (#876)
Michaelvll Jun 1, 2022
9825303
Minor: reformat `sky show-gpus` output. (#877)
concretevitamin Jun 1, 2022
d18eb7c
Distinguish spot failure for user code and cluster/controller failure…
Michaelvll Jun 1, 2022
5b81718
Add YAML schema check (#680)
gmittal Jun 1, 2022
06f16b4
Add explanations on spot docs (#852)
infwinston Jun 2, 2022
a53e013
Fix typo (#880)
Michaelvll Jun 2, 2022
f3c865e
Make `sky launch` prompting consistent with interactive nodes (#867)
gmittal Jun 2, 2022
a4b0d28
Make the spot job pending as soon as the job is submitted (#870)
Michaelvll Jun 2, 2022
b5040ae
remove azureTokens.json from the credential list (#883)
Michaelvll Jun 2, 2022
518cfa2
Fast removal of buckets
michaelzhiluo Jun 2, 2022
52f01e5
Fast removal of buckets
michaelzhiluo Jun 2, 2022
6c4d32b
Replace os.system with subprocess
michaelzhiluo Jun 2, 2022
b1ed515
Replace os.system with subprocess
michaelzhiluo Jun 2, 2022
2649f5e
fix syntax
michaelzhiluo Jun 2, 2022
03dd2af
fix syntax
michaelzhiluo Jun 2, 2022
bad31d5
Merge branch 'storage_fast_delete' of https://github.com/sky-proj/sky…
michaelzhiluo Jun 6, 2022
78e656e
Addressed Romil's comments
michaelzhiluo Jun 6, 2022
ccc32c6
Merge branch 'master' of https://github.com/sky-proj/sky into storage…
michaelzhiluo Jun 6, 2022
f08c7bd
fix comment
michaelzhiluo Jun 6, 2022
9b86bdf
Fix comments 2
michaelzhiluo Jun 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix order of setup (#593)
  • Loading branch information
Michaelvll authored Mar 16, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 8a28dc4be58031467ab7fa8690918299e422809f
2 changes: 1 addition & 1 deletion sky/backends/cloud_vm_ray_backend.py
Original file line number Diff line number Diff line change
@@ -1518,7 +1518,7 @@ def _setup_node(ip: int) -> int:
target=f'/tmp/{setup_file}',
stream_logs=False)
# Need this `-i` option to make sure `source ~/.bashrc` work
cmd = f'/bin/bash -i /tmp/{setup_file}'
cmd = f'/bin/bash -i /tmp/{setup_file} 2>&1'
returncode = backend_utils.run_command_on_ip_via_ssh(
ip,
cmd,