[k8s] Parallelize multi-node setup #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o k8s_disable_ssh
Michaelvll
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Thanks for making the change @romilbhardwaj! Looks mostly good to me.
sky/provision/kubernetes/instance.py
Outdated
Comment on lines
462
to
463
| if not provider_config.get('disable_ssh', False): | ||
| ssh_install_cmd = install_ssh_k8s_cmd |
There was a problem hiding this comment.
Do we still need this? If we do, how much faster this change will offer?
There was a problem hiding this comment.
Ah I forgot to push my changes last night. The disable_ssh flag has been removed now.
Michaelvll
approved these changes
Nov 8, 2024
…o k8s_multinode_perf # Conflicts: # sky/templates/kubernetes-ray.yml.j2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4261 and #4270.
We identified that
apt updateis the slowest operation and triggering it after setup takes a lot of time, so we now inline it in container init args to let kubernetes run it in parallel.Testing on nemo image
sky launch -y -c test --num-nodes 100 --cloud kubernetes --image-id nvcr.io/nvidia/nemo:24.05.01Master branch: 19:56.21 total
This branch: 15:26.56 total
Testing on default image:
sky launch -y -c test --num-nodes 100 --cloud kubernetesThis branch: 4:13.41 total
Tested (run the relevant ones):
bash format.sh