New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Add tags on bucket creation time #3922

Merged

romilbhardwaj merged 2 commits into skypilot-org:master from shashank2000:shashank/add_tags_to_buckets

Sep 9, 2024

Contributor

shashank2000 commented Sep 6, 2024

Adding ability to add tags from global config to buckets created

Code formatting: bash format.sh
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh


          add tags on creation time

71315a9

shashank2000 force-pushed the shashank/add_tags_to_buckets branch from 415ecf0 to 71315a9 Compare

September 6, 2024 20:48


          Update comments and docs

6ca0429

romilbhardwaj changed the title ~~add tags on bucket creation time~~ [AWS] Add tags on bucket creation time

romilbhardwaj approved these changes

View reviewed changes

Collaborator

romilbhardwaj left a comment

Thanks @shashank2000. Pushed some updates to docs/comments, LGTM.

romilbhardwaj added this pull request to the merge queue

Merged via the queue into skypilot-org:master with commit d46fb63

20 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet