[k8s] Suppress insecure request warnings #3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Aug 29, 2024
sky/adaptors/kubernetes.py
Outdated
| @@ -18,6 +18,8 @@ | |||
| urllib3 = common.LazyImport('urllib3', | |||
| import_error_message=_IMPORT_ERROR_MESSAGE) | |||
|
|
|||
| urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) | |||
There was a problem hiding this comment.
This will cause urllib3 being imported when the adaptors being imported, which may cause errors when skypilot is not installed with skypilot[kubernetes] or skypilot[all].
There was a problem hiding this comment.
Actually, we only specify urllib3 in the dependency of aws, we should have it specified for kubernetes as well in setup.py
There was a problem hiding this comment.
Good point, I have moved it to _load_config so that it is invoked only when a) _configured=False and b) other import checks have already been run.
urllib3 does not need to be explicitly specified in setup.py, since the kubernetes package depends on urllib3 and urllib3 will automatically be installed when kubernetes is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user uses disables tls for k8s with
insecure-skip-tls-verifyin their kubeconfig, urllib3 prints warnings for each connection:This PR disables warnings with the method recommended by urllib3.
Tested (run the relevant ones):
bash format.sh