[Azure] Use SkyPilot provisioner for status query #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
11 tasks
cblmemo
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Thanks for updating this @Michaelvll ! It looks great to me 🚀 Left several nits, other than that it is ready to go!
…o azure-query-status
…o azure-query-status
Michaelvll
added a commit
that referenced
this pull request
Aug 23, 2024
* Use SkyPilot for status query * format * Avoid reconfig * Add todo * Fix filtering for autodown clusters * remove comment * Address comments * typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses SkyPilot provisioned to query the VM status for Azure, making it more robust against the original CLI-based query.
Tested (run the relevant ones):
bash format.shsky launch -c test-azure-query -i 0 --cloud azure --cpus 2 echo hifor i in `seq 1 10000`; do sky status -r test-azure-query; donesky autostop --down -i 0 test-azure-queryfor i in `seq 1 10000`; do sky status -r test-azure-query; donesky launch -c test-azure-query -i 0 --cloud azure --cpus 2 --num-nodes 2 echo hifor i in `seq 1 10000`; do sky status -r test-azure-query; donefor i in `seq 1 10`; do sky launch --cloud azure --cpus 2 --num-nodes 2 -y echo hi; doneandsky status -rpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh