Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix inline script length checking #3663

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jun 13, 2024

A user reported that the following task yaml fails:

num_nodes: 30

setup: echo setup
run: echo run

This is due to the length checking before does not include the quotes, which will add significant length. We derived the current threshold with binary search.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll requested a review from cblmemo June 13, 2024 04:45
@Michaelvll Michaelvll merged commit 44c7ec8 into master Jun 13, 2024
20 checks passed
@Michaelvll Michaelvll deleted the fix-inline-script-length-threshold branch June 13, 2024 20:44
Michaelvll added a commit that referenced this pull request Aug 23, 2024
* [Core] Fix inline script length checking

* format

* fix comment

* fix name

* format

* rename

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants