[Core] Fix inline script length checking #3663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that the following task yaml fails:
This is due to the length checking before does not include the quotes, which will add significant length. We derived the current threshold with binary search.
Tested (run the relevant ones):
bash format.sh
for i in `seq 1 8511`; do echo " echo $i" >> test.yaml; done
(not trigger file upload)for i in `seq 1 8512`; do echo " echo $i" >> test.yaml; done
(not trigger file upload)pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh