[Core] Fix status refresh for INIT cluster #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Aug 30, 2023
sky/backends/backend_utils.py
Outdated
| logger.debug( | ||
| f'Refreshing status ({cluster_name!r}): failed ' | ||
| f'to get the ssh ports. Handle: {handle}') | ||
| raise exceptions.FetchIPError( |
There was a problem hiding this comment.
Shall we use a new exception named FetchPortError instead?
There was a problem hiding this comment.
Changed to RuntimeError, as this error is only internal facing and should not be raised in most cases, we probably don't want to add a new exception. Wdyt?
cblmemo
approved these changes
Aug 31, 2023
sky/backends/backend_utils.py
Outdated
| raise exceptions.FetchIPError( | ||
| reason=exceptions.FetchIPError.Reason.HEAD) | ||
|
|
||
| if handle.head_ssh_port is None: | ||
| # Refresh the ssh ports. It is ok to refresh as it is fast. | ||
| handle.external_ssh_ports() |
There was a problem hiding this comment.
Shall we use update_ssh_ports for better readability?
There was a problem hiding this comment.
Good point! Actually, we don't need to handle this None or refresh case, as we already have it in the external_ssh_ports call. changed to that instead.
sky/backends/backend_utils.py
Outdated
| logger.debug( | ||
| f'Refreshing status ({cluster_name!r}): failed ' | ||
| f'to get the ssh ports. Handle: {handle}') | ||
| raise exceptions.FetchIPError( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2490
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh