Adding isort

[gbmarc1]

Adding isort and executing

Tested (run the relevant ones):

• Code formatting: bash format.sh
• Any manual or new tests for this PR (please specify below)
• All smoke tests: pytest tests/test_smoke.py
• Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
• Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

[concretevitamin]

Thanks a lot for adding this, @gbmarc1! Look great. Left some nits.

[concretevitamin]

+1 that we want to skip formatting sky/skylet/providers/{aws,gcp,azure}. Reason is those files are forked from upstream Ray, and each time when we do a Ray dependency upgrade, we do a diff against the upstream files to understand whether our genuine changes are affected.

However, it seems like this PR has changed files under those dirs?

.../ibm should be okay to be isort-ed since it's not forked from Ray.

[concretevitamin]

(See other comment) Some files under these dirs seem formatted.

[gbmarc1]

I added isort with the black profile (L120) since they were already formatted by black (L105-106).
They are formatted but it seems that mostly things that were moved were sky imports.

[concretevitamin]

Discussed with @Michaelvll. The imports being formatted may still hinder humans (us :)) looking at diffs when we're upgrading Ray. Can we skip formatting sky/skylet/providers/{aws,gcp,azure} even with the black profile, both in format.sh and in .github/workflows/format.yml?

[gbmarc1]

yes will do

[concretevitamin]

Discussed with @Michaelvll. The imports being formatted may still hinder humans (us :)) looking at diffs when we're upgrading Ray. Can we skip formatting sky/skylet/providers/{aws,gcp,azure} even with the black profile, both in format.sh and in .github/workflows/format.yml?

[concretevitamin]

Smoke tests all passed:

• pytest tests/test_smoke.py --aws

We can merge this after consensus on that nit (excluding some providers)!

[concretevitamin]

Some conflicts need to be resolved: maybe

git merge master
git checkout master -- sky/skylet/providers/{aws,gcp,azure}

?

[concretevitamin]

Thanks for this awesome addition @gbmarc1! Merging.

[invisiblepancake]

okie dokie?