Fix creating $PWD/~/sky_logs in some cases.
#2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Jun 2, 2023
|
LGTM too 🫡 |
concretevitamin
added a commit
that referenced
this pull request
Jun 3, 2023
concretevitamin
added a commit
that referenced
this pull request
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the report from a user. #1913 had a bug where sometimes we call
os.makedirs('~/sky_logs/...', ...), causing$PWD/~/sky_logsto be created in some cases.Repro:
With this PR, the above succeeds &
$PWD/~/sky_logsis no longer created.cc @cblmemo to take a look too.
Tested (run the relevant ones):
pytest tests/test_smoke.py: runningpytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh