Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui):text on popup action change if need update comment & fixes default size on comment diallog #2376

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

MrIkso
Copy link
Contributor

@MrIkso MrIkso commented Dec 19, 2024

This PR fixes #2155

@skylot
Copy link
Owner

skylot commented Dec 20, 2024

@MrIkso thanks for the fix. I updated it to just rename labels, instead of adding and changing to a new action. That new action also appears in key binding settings, and this it feels not right.

@skylot skylot merged commit 8345edf into skylot:master Dec 20, 2024
4 checks passed
@MrIkso
Copy link
Contributor Author

MrIkso commented Dec 20, 2024

@skylot thanks, I first used setName but replaced it to set the new action. Okay, I'll keep that in mind.

@MrIkso MrIkso deleted the improve_comment_dialog branch December 20, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment text box not shown
2 participants