Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning from numpy 1.19.3 #506

Closed
mworion opened this issue Dec 17, 2020 · 6 comments
Closed

Deprecation Warning from numpy 1.19.3 #506

mworion opened this issue Dec 17, 2020 · 6 comments

Comments

@mworion
Copy link

mworion commented Dec 17, 2020

@brandon-rhodes ,
I get during my tests a warning in skyfield 1.34:

/Users/mw/PycharmProjects/Envs/mw4/lib/python3.8/site-packages/skyfield/earthlib.py:53: VisibleDeprecationWarning: Creating an ndarray from ragged nested sequences (which is a list-or-tuple of lists-or-tuples-or ndarrays with different lengths or shapes) is deprecated. If you meant to do this, you must specify 'dtype=object' when creating the ndarray vel = ANGVEL * DAY_S * array((-acsst, accst, zero))

Michel

@brandon-rhodes
Copy link
Member

Interesting. That line of code will with the next release of Skyfield (which will probably happen tomorrow) stop being run as part of the mainline calculations. I'll update this issue once the release has gone out so you can test. Or, if you want to test immediately to see whether the new version will still trigger it:

pip install https://github.com/skyfielders/python-skyfield/archive/master.zip

@mworion
Copy link
Author

mworion commented Dec 17, 2020

Hi Brandon,

thanks for the immediate answer. No hurry, I just recognized it during tests. No functional issue for me so far.

Michel

@mworion
Copy link
Author

mworion commented Dec 17, 2020

...check done, same warning with the actual master....

@brandon-rhodes
Copy link
Member

Thanks for checking! I'll see if I can temporarily install that NumPy version locally and get the problem solved.

brandon-rhodes added a commit that referenced this issue Jan 2, 2021
Just happened to run across this one while working on #524.
@mworion
Copy link
Author

mworion commented Jan 18, 2021

@brandon-rhodes
Just to give you a quick hint relating your fix: it works in my environment with actual master. The warning is gone.
Many thanks !
Michel

@brandon-rhodes
Copy link
Member

Thanks! I'll mark this as complete, then, and at the next release the solution will go out to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants