Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for HsvColorPicker initialColor #28

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

tberghuis
Copy link
Contributor

No description provided.

@tberghuis tberghuis requested a review from skydoves as a code owner July 3, 2023 03:12
@skydoves
Copy link
Owner

skydoves commented Jul 5, 2023

Hey @tberghuis, thanks for your contribution. Would you elaborate on this PR?

@tberghuis
Copy link
Contributor Author

The picker was selecting the wrong color for initialColor, the angle just needed to be in the negative direction.

I have found other problems like if you place HsvColorPicker in a scrollable column, sliding the picker doesn't work properly. Also picker position gets reset to initialColor on configuration change (screen rotate).

Decided not to use this library for now.

@skydoves
Copy link
Owner

skydoves commented Jul 5, 2023

@tberghuis thanks for your explanation and contribution. The scrollable issue was resolved in #29. This PR and many feature improvements will be shipped in the next release very soon. Thanks.

@skydoves skydoves merged commit 6b4469b into skydoves:main Jul 5, 2023
@tberghuis
Copy link
Contributor Author

I think having initialColor and state as part of the controller would be a better design. Would allow keeping Controller in a ViewModel to eliminate configuration change bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants