Merge pull request #186 from skydoves/fix/dismiss-when-lifecycle-pause

Invoke dismiss() instead of the onDestroy() on Pause lifecycle event
skydoves · Apr 21, 2021 · ba0df2a · ba0df2a
2 parents 8984605 + 0fafcfd
commit ba0df2a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/app/src/main/java/com/skydoves/balloondemo/factory/ProfileBalloonFactory.kt b/app/src/main/java/com/skydoves/balloondemo/factory/ProfileBalloonFactory.kt
@@ -44,6 +44,7 @@ class ProfileBalloonFactory : Balloon.Factory() {
       setBalloonAnimation(BalloonAnimation.CIRCULAR)
       setDismissWhenTouchOutside(true)
       setDismissWhenShowAgain(true)
+      setDismissWhenLifecycleOnPause(true)
       setLifecycleOwner(lifecycle)
     }
   }

diff --git a/balloon/src/main/java/com/skydoves/balloon/Balloon.kt b/balloon/src/main/java/com/skydoves/balloon/Balloon.kt
@@ -1092,7 +1092,7 @@ class Balloon(
   @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE)
   fun onPause() {
     if (builder.dismissWhenLifecycleOnPause) {
-      onDestroy()
+      dismiss()
     }
   }