Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normal e2e tests #246

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Fix normal e2e tests #246

merged 1 commit into from
Oct 11, 2018

Conversation

Senyoret1
Copy link
Contributor

In this repository it is possible to execute e2e tests with both npm run e2e and npm run e2e-blockchain-180. npm run e2e-blockchain-180 is used to run the tests in Travis, using a limited and controlled database, but that command is inconvenient to run the tests during normal development, because it involves using a node with blockchain-180.db, that's why npm run e2e exists, to be able to run the tests with a normal node.

This PR makes the configuration of npm run e2e to be more similar to that of npm run e2e-blockchain-180, to avoid some problems that occurred only when executing npm run e2e.

@olemis
Copy link
Contributor

olemis commented Oct 10, 2018

Do you use make or similar? It'd be possible to have different (reusable) make targets for each situation .

@Senyoret1
Copy link
Contributor Author

It uses npm, which is somewhat similar to using make. The problem was simply that in the two configurations a different screen resolutions was used and that changed some of the contents due to the responsive design. This PR simply fixes that

@gz-c gz-c merged commit d4c432c into skycoin:develop Oct 11, 2018
@gz-c
Copy link
Member

gz-c commented Oct 11, 2018

@Senyoret1 in skycoin/skycoin, we've changed blockchain-180.db to include a unconfirmed transaction. The original db file is now blockchain-180-no-unconfirmed.db. You may want to use the updated database in order to test the unconfirmed page

@Senyoret1
Copy link
Contributor Author

@gz-c It was already done in #238 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants