Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builders for BBAN and IBAN. #27

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Add builders for BBAN and IBAN. #27

merged 1 commit into from
Oct 9, 2020

Conversation

skwasjer
Copy link
Owner

@skwasjer skwasjer commented Oct 9, 2020

Adds two simple builders for IBAN and BBAN.

  • both builders depend on a country code supported by the registry
  • ability to auto pad account numbers
  • computes valid check digit (IBAN only)

Note that both builders do not ensure actual validity, as you can supply the builder methods with any textual data.

In relation to #21 as a prerequisite to support generating pseudo random account numbers (for testing purposes).

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #27 into develop will decrease coverage by 0.44%.
The diff coverage is 90.81%.

Impacted Files Coverage Δ
...rc/IbanNet/Builders/BankAccountBuilderException.cs 25.00% <25.00%> (ø)
src/IbanNet/Builders/BbanBuilder.cs 92.85% <92.85%> (ø)
src/IbanNet/Builders/BuilderExtensions.cs 100.00% <100.00%> (ø)
src/IbanNet/Builders/IbanBuilder.cs 100.00% <100.00%> (ø)
src/IbanNet/Extensions/ArrayExtensions.cs 100.00% <100.00%> (ø)

@codecov-commenter
Copy link

Codecov Report

Merging #27 into develop will decrease coverage by 0.44%.
The diff coverage is 90.81%.

Impacted Files Coverage Δ
...rc/IbanNet/Builders/BankAccountBuilderException.cs 25.00% <25.00%> (ø)
src/IbanNet/Builders/BbanBuilder.cs 92.85% <92.85%> (ø)
src/IbanNet/Builders/BuilderExtensions.cs 100.00% <100.00%> (ø)
src/IbanNet/Builders/IbanBuilder.cs 100.00% <100.00%> (ø)
src/IbanNet/Extensions/ArrayExtensions.cs 100.00% <100.00%> (ø)

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #27 into develop will decrease coverage by 0.44%.
The diff coverage is 90.81%.

Impacted Files Coverage Δ
...rc/IbanNet/Builders/BankAccountBuilderException.cs 25.00% <25.00%> (ø)
src/IbanNet/Builders/BbanBuilder.cs 92.85% <92.85%> (ø)
src/IbanNet/Builders/BuilderExtensions.cs 100.00% <100.00%> (ø)
src/IbanNet/Builders/IbanBuilder.cs 100.00% <100.00%> (ø)
src/IbanNet/Extensions/ArrayExtensions.cs 100.00% <100.00%> (ø)

@skwasjer skwasjer merged commit 79a73a4 into develop Oct 9, 2020
@skwasjer skwasjer added this to the v4.2 milestone Nov 26, 2020
@skwasjer skwasjer deleted the feature/builders branch November 27, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants