Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes phantom process records observed in the console UI #1341

Merged

Conversation

c-kruse
Copy link
Contributor

@c-kruse c-kruse commented Jan 3, 2024

Only persist new process records when their EndTime is unset. When a message containing a record update setting process EndTime is delivered multiple times, subsequent deliveries should be ignored.

Only persist new process records when their EndTime is unset. When a
message containing a record update setting process EndTime is delivered
multiple times, subsequent deliveries should be ignored.
@c-kruse c-kruse marked this pull request as ready for review January 3, 2024 21:10
@c-kruse c-kruse requested review from ajssmith and bartoval January 3, 2024 21:10
Copy link
Member

@ajssmith ajssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

Copy link
Member

@bartoval bartoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill phantoms 🥇
Thanks!

@c-kruse c-kruse merged commit 872b00e into skupperproject:main Jan 3, 2024
1 check passed
nluaces pushed a commit that referenced this pull request Jan 8, 2024
Only persist new process records when their EndTime is unset. When a
message containing a record update setting process EndTime is delivered
multiple times, subsequent deliveries should be ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants