Fixes #365 - Replace valgrind with sanitizers in Containerfile #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
commented
Apr 21, 2022
| @@ -74,5 +74,10 @@ ARG version=latest | |||
| ENV VERSION=${version} | |||
| ENV QDROUTERD_HOME=/home/skrouterd | |||
|
|
|||
| ENV ASAN_OPTIONS="disable_coredump=0 detect_odr_violation=0 strict_string_checks=1 detect_stack_use_after_return=1 check_initialization_order=1 strict_init_order=1 detect_invalid_pointer_pairs=2" | |||
| ENV LSAN_OPTIONS="disable_coredump=0 suppressions=/lsan.supp" | |||
There was a problem hiding this comment.
lsan needs to use ptrace, which requires capabilities, for which I tend to run container with --privileged. Afaik this is no different from gdb, and therefore is not a problem.
one solution (to have asan without lsan) would be to define here detect_leaks=0.
jiridanek
commented
Apr 21, 2022
Comment on lines
+70
to
+72
| do_build "" OFF | ||
| do_build "_asan" asan | ||
| do_build "_tsan" tsan |
There was a problem hiding this comment.
The image build used to take 6 mins on GHA, this PR ran 14 minutes. Too bad. Each of these builds is different (different gcc options) so there is no space for any caching or such ways.
jiridanek
commented
Apr 21, 2022
Comment on lines
35
to
+36
| elif [[ $QDROUTERD_DEBUG = "valgrind" ]]; then | ||
| exec valgrind skrouterd $ARGS | ||
| exec skrouterd_asan $ARGS |
There was a problem hiding this comment.
backward compatibility ftw!
|
Contained in #372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.