Fixes #1732: implement new Admin Connector type #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| item->scheme = strdup("amqp"); | ||
| item->host = strdup(admin_conn->config.host); | ||
| item->port = strdup(admin_conn->config.port); | ||
| int hplen = strlen(item->host) + strlen(item->port) + 2; |
Check warning
Code scanning / GNU C11
use of possibly-NULL 'strdup(*admin_conn.config.host)' where non-null expected Warning
| item->scheme = strdup("amqp"); | ||
| item->host = strdup(admin_conn->config.host); | ||
| item->port = strdup(admin_conn->config.port); | ||
| int hplen = strlen(item->host) + strlen(item->port) + 2; |
Check warning
Code scanning / GNU C11
use of possibly-NULL 'strdup(*admin_conn.config.port)' where non-null expected Warning
ganeshmurthy
reviewed
Feb 5, 2025
| @@ -168,49 +166,53 @@ static int get_failover_info_length(qd_failover_item_list_t conn_info_list) | |||
| */ | |||
| QD_EXPORT qd_error_t qd_entity_refresh_connector(qd_entity_t* entity, void *impl) | |||
| { | |||
| qd_connector_t *connector = (qd_connector_t*) impl; | |||
| qd_admin_connector_t *admin_conn = (qd_admin_connector_t *) impl; | |||
There was a problem hiding this comment.
Suggested change
| qd_admin_connector_t *admin_conn = (qd_admin_connector_t *) impl; | |
| qd_admin_connector_t *admin_connector = (qd_admin_connector_t *) impl; | |
| `` | |
| Someone might look at `admin_conn` somewhere in the code and think of it as an admin connection instead of an admin connector |
o) rename qd_admin_connector_t --> qd_connector_config_t o) change "admin_conn" to "ctor_config" o) Use "ctor" as shorthand for "connector" in API and local vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.