-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
system_tests_topology_disposition: KeyError: 'name' #1041
Comments
(this is a flaky fail, it passed upon rerun, https://github.com/skupperproject/skupper-router/actions/runs/4585208141/jobs/8101560431) |
Perfect! That new code I added to the test dumps the message that is failing to parse. Now we have something to look at! Looks like a test bug. The part of the code that throws the key error is expecting the response to a query for "io.skupper.router.connector" in map form. Specifically: {'type': 'io.skupper.router.connector', 'name': 'AB_connector', But when the failure happens the message is not a response to a connection query. Instead it is a response to a link query. From the test failure logs: body={'attributeNames': ['linkType', 'linkDir', 'linkName', 'owningAddr', 'capacity', 'undeliveredCount', 'unsettledCount', 'acceptedCount', 'rejectedCount', 'releasedCount', 'modifiedCount'],'results': [['router-control', 'out', So there's a bug in the test state machine where it expects a different type of error. |
And here's the problem with the test: 2023-04-01T21:12:48.4123419Z 36: 1680383568.028513 topo check found connector AD_connector The test has found all the connectors and proceeds to the link check state where it issues link queries. Then a new link comes up. The on_link_opened event fires which unconditionally (and incorrectly) transitions the test back to topo checking. This causes the test to assume the management query response is for a connection query, where in fact the response is from a link query. IIUC the real fix is to not transition to topo checking until after all the management links have finished coming up. |
https://github.com/skupperproject/skupper-router/actions/runs/4585208141/jobs/8097248918#step:10:2557
This is in the new code merged by @kgiusti recently in #963
The text was updated successfully, but these errors were encountered: