Fixes #1532: Fixed leaking duplicate file descriptor

skupperproject · Jun 24, 2024 · 3e11f53 · 3e11f53
1 parent d823211
commit 3e11f53
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/router/src/main.c b/router/src/main.c
@@ -168,8 +168,20 @@ static void daemon_process(const char *config_path, const char *python_pkgdir, b
             close(0);
             int fd = open("/dev/null", O_RDWR);
             if (fd != 0) fail(pipefd[1], "Can't redirect stdin to /dev/null");
-            if (dup(fd) < 0) fail(pipefd[1], "Can't redirect stdout to /dev/null");
-            if (dup(fd) < 0) fail(pipefd[1], "Can't redirect stderr /dev/null");
+
+            int fd1 = dup(fd);
+            if (fd1 < 0) {
+                close(fd1);
+                fail(pipefd[1], "Can't redirect stdout to /dev/null");
+            }
+            close(fd1);
+
+            int fd2 = dup(fd);
+            if (fd2 < 0) {
+                close(fd2);
+                fail(pipefd[1], "Can't redirect stderr /dev/null");
+            }
+            close(fd2);
 
             //
             // Set the umask to 0