-
Notifications
You must be signed in to change notification settings - Fork 9
disable service sync with yaml and consume service remotely #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* tls concepts
* update link-cost
@sjhiggs could you take a look? |
@hash-d Could you take a look? The idea is to document
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instructions are clear and I was able to execute the task as documented.
I put a few suggestions, but I'm not sure whether they fit on the document's flow or they'd make it too verbose.
lgtm
|
||
---- | ||
include::../examples/no-ingress.yaml[] | ||
---- | ||
|
||
NOTE: By default, `service-sync` is enabled and if you create a service on one site, it is available on all sites. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about using 'available' here. The skupper service is still available on all sites. The difference is that without the service-sync a k8s service will not be automatically created on this site.
Perhaps something along the lines
By default
service-sync
is enabled, and a Kubernetes service is automatically created locally for each/every/all skupper services present on the VAN
- name: http | ||
protocol: TCP | ||
port: 8080 | ||
targetPort: 8080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three places where 'port' is set; it might be interesting to explain what's the role of each of them, especially given that one of them will be overwritten by Skupper.
name: backend | ||
annotations: | ||
skupper.io/proxy: tcp | ||
skupper.io/address: backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be interesting to mention that this needs to match the name of the service created on the other side, as that will be the main alteration the user will do on this file.
No description provided.