Skip to content

Commit

Permalink
fix #82 Nest 8 bug.
Browse files Browse the repository at this point in the history
  • Loading branch information
GyanendroKh committed Jul 25, 2021
1 parent 0715fe6 commit 0b1f99a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 15 deletions.
6 changes: 3 additions & 3 deletions dist/redis-core.module.d.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { DynamicModule, OnModuleDestroy } from '@nestjs/common';
import { ModuleRef } from '@nestjs/core';
import { RedisModuleAsyncOptions, RedisModuleOptions } from './redis.interface';
import { RedisClient } from './redis-client.provider';
export declare class RedisCoreModule implements OnModuleDestroy {
private readonly options;
private readonly moduleRef;
constructor(options: RedisModuleOptions | RedisModuleOptions[], moduleRef: ModuleRef);
private readonly redisClient;
constructor(options: RedisModuleOptions | RedisModuleOptions[], redisClient: RedisClient);
static register(options: RedisModuleOptions | RedisModuleOptions[]): DynamicModule;
static forRootAsync(options: RedisModuleAsyncOptions): DynamicModule;
onModuleDestroy(): void;
Expand Down
13 changes: 6 additions & 7 deletions dist/redis-core.module.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,13 @@ var RedisCoreModule_1;
Object.defineProperty(exports, "__esModule", { value: true });
exports.RedisCoreModule = void 0;
const common_1 = require("@nestjs/common");
const core_1 = require("@nestjs/core");
const redis_client_provider_1 = require("./redis-client.provider");
const redis_constants_1 = require("./redis.constants");
const redis_service_1 = require("./redis.service");
let RedisCoreModule = RedisCoreModule_1 = class RedisCoreModule {
constructor(options, moduleRef) {
constructor(options, redisClient) {
this.options = options;
this.moduleRef = moduleRef;
this.redisClient = redisClient;
}
static register(options) {
return {
Expand All @@ -43,15 +42,14 @@ let RedisCoreModule = RedisCoreModule_1 = class RedisCoreModule {
};
}
onModuleDestroy() {
const closeConnection = ({ clients, defaultKey }) => options => {
const closeConnection = ({ clients, defaultKey }) => (options) => {
const name = options.name || defaultKey;
const client = clients.get(name);
if (client && !options.keepAlive) {
client.disconnect();
}
};
const redisClient = this.moduleRef.get(redis_constants_1.REDIS_CLIENT);
const closeClientConnection = closeConnection(redisClient);
const closeClientConnection = closeConnection(this.redisClient);
if (Array.isArray(this.options)) {
this.options.forEach(closeClientConnection);
}
Expand All @@ -67,6 +65,7 @@ RedisCoreModule = RedisCoreModule_1 = __decorate([
exports: [redis_service_1.RedisService],
}),
__param(0, common_1.Inject(redis_constants_1.REDIS_MODULE_OPTIONS)),
__metadata("design:paramtypes", [Object, core_1.ModuleRef])
__param(1, common_1.Inject(redis_constants_1.REDIS_CLIENT)),
__metadata("design:paramtypes", [Object, Object])
], RedisCoreModule);
exports.RedisCoreModule = RedisCoreModule;
9 changes: 4 additions & 5 deletions lib/redis-core.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
Inject,
OnModuleDestroy,
} from '@nestjs/common';
import { ModuleRef } from '@nestjs/core';
import { RedisModuleAsyncOptions, RedisModuleOptions } from './redis.interface';
import {
createAsyncClientOptions,
Expand All @@ -25,7 +24,8 @@ export class RedisCoreModule implements OnModuleDestroy {
constructor(
@Inject(REDIS_MODULE_OPTIONS)
private readonly options: RedisModuleOptions | RedisModuleOptions[],
private readonly moduleRef: ModuleRef,
@Inject(REDIS_CLIENT)
private readonly redisClient: RedisClient,
) {}

static register(
Expand All @@ -51,7 +51,7 @@ export class RedisCoreModule implements OnModuleDestroy {
}

onModuleDestroy() {
const closeConnection = ({ clients, defaultKey }) => options => {
const closeConnection = ({ clients, defaultKey }) => (options) => {
const name = options.name || defaultKey;
const client = clients.get(name);

Expand All @@ -60,8 +60,7 @@ export class RedisCoreModule implements OnModuleDestroy {
}
};

const redisClient = this.moduleRef.get<RedisClient>(REDIS_CLIENT);
const closeClientConnection = closeConnection(redisClient);
const closeClientConnection = closeConnection(this.redisClient);

if (Array.isArray(this.options)) {
this.options.forEach(closeClientConnection);
Expand Down

0 comments on commit 0b1f99a

Please sign in to comment.