New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split clippy-reviewdog-filter pipe to mitigate broken pipe #60

Merged

sksat merged 2 commits into main from split-pipe-to-mitigate-broken-pipe

Jan 15, 2024

Owner

sksat commented Jan 15, 2024

Sometimes (especially during on:push) Broken pipe occurs
- ex: mainのCIが失敗している arkedge/c2a-tlmcmddb#42 (https://github.com/arkedge/c2a-tlmcmddb/actions/runs/7523751359/job/20485143596)
The root cause of this is that SIGPIPE is ignored in Rust's default behavior
Therefore, temporarily stop pipe directly & passing checkstyle XML to reviewdog via temporary file


          split clippy-reviewdog-filter pipe to mitigate broken pipe

471d119

sksat added the bug label

sksat self-assigned this


          add comment

3459b29

sksat merged commit a23dfaa into main

2 checks passed

sksat deleted the split-pipe-to-mitigate-broken-pipe branch

January 15, 2024 10:43

sksat linked an issue

that may be closed by this pull request

Closed

Owner Author

sksat commented Jan 15, 2024

PR to clippy-reviewdog-filter: qnighy/clippy-reviewdog-filter#171

sksat mentioned this pull request

Revert "Split clippy-reviewdog-filter pipe to mitigate broken pipe" #64

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug