Implement stats redis command #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrochalakis
reviewed
Sep 6, 2017
stats.go
Outdated
| func (s *Stats) toSlice() []interface{} { | ||
| return []interface{}{ | ||
| "producer.unflushed.messages", | ||
| strconv.FormatInt(atomic.LoadInt64(&s.producerUnflushed), 10), |
There was a problem hiding this comment.
Can we use an integer type as the value? the redisproto should support it.
There was a problem hiding this comment.
Package atomic has no int alias. We either have to use int32 or int64.
ctrochalakis
reviewed
Sep 6, 2017
stats.go
Outdated
| producerErr int64 | ||
| } | ||
|
|
||
| func (s *Stats) toSlice() []interface{} { |
charkost
approved these changes
Sep 6, 2017
This allows users to monitor Rafka for errors that are not propagated to the clients. Until now such errors were just being logged. It allows for simple alerting rules (eg. alert when producer errors are more than 10). We used the HGETALL Redis command, since the stats structure can be considered a hash with stat names as keys and counters as values. Part of #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to monitor Rafka for errors that are not propagated to
the clients. Until now such errors were just being logged. It allows for
simple alerting rules (eg. alert when producer errors are more than 10).
We used the HGETALL Redis command, since the stats structure can be
considered a hash with stat names as keys and counters as values.
Part of #28