Skip to content

Commit

Permalink
chore(typing): add CompliantExpr._version (narwhals-dev#2060)
Browse files Browse the repository at this point in the history
Mentioned in https://discord.com/channels/1235257048170762310/1272835922924273694/1342486928250900570
All impls of the protocol already define this
  • Loading branch information
dangotbanned authored Feb 21, 2025
1 parent 4dda548 commit 44324b9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions narwhals/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from narwhals.expr import Expr
from narwhals.series import Series
from narwhals.utils import Implementation
from narwhals.utils import Version

# All dataframes supported by Narwhals have a
# `columns` property. Their similarities don't extend
Expand Down Expand Up @@ -79,6 +80,7 @@ def aggregate(self, *exprs: Any) -> Self:
class CompliantExpr(Protocol, Generic[CompliantSeriesT_co]):
_implementation: Implementation
_backend_version: tuple[int, ...]
_version: Version
_evaluate_output_names: Callable[
[CompliantDataFrame | CompliantLazyFrame], Sequence[str]
]
Expand Down

0 comments on commit 44324b9

Please sign in to comment.