-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning from torch.load starting in torch 2.4 #1064
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
97a81ea
Fix warning from torch.load starting in torch 2.4
BenjaminBossan 9acfb84
Reviewer feedback: return kwargs directly
BenjaminBossan ab9c536
Reviewer feedback: One more test w/o monkeypatch
BenjaminBossan f4162ac
Reviewer feedback: rename function, fix typo
BenjaminBossan 8b66f98
Merge branch 'master' into fix-torch-load-warning-weights-only
BenjaminBossan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -28,6 +28,7 @@ | |||||
|
||||||
from skorch.exceptions import DeviceWarning | ||||||
from skorch.exceptions import NotInitializedError | ||||||
from ._version import Version | ||||||
|
||||||
try: | ||||||
import torch_geometric | ||||||
|
@@ -768,3 +769,18 @@ def _check_f_arguments(caller_name, **kwargs): | |||||
key = 'module_' if key == 'f_params' else key[2:] + '_' | ||||||
kwargs_module[key] = val | ||||||
return kwargs_module, kwargs_other | ||||||
|
||||||
|
||||||
def get_torch_load_kwargs(): | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"""Returns the kwargs passed to torch.load the correspond to the current | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
torch version. | ||||||
|
||||||
The plan is to switch from weights_only=False to True in PyTorch version | ||||||
2.6.0, but depending on what happens, this may require updating. | ||||||
|
||||||
""" | ||||||
version_torch = Version(torch.__version__) | ||||||
version_default_switch = Version('2.6.0') | ||||||
if version_torch >= version_default_switch: | ||||||
return {"weights_only": True} | ||||||
return {"weights_only": False} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.