Commits on Feb 8, 2024

1. Fix issues with sklearn 1.4 …

   DON'T MERGE YET.
   
   Some skorch tests fail with sklearn v1.4. This commit fixes them:
   
   1. Inheritance structure of scorers seems to have changed.
   2. classes_ attribute should always be numpy array
   3. CalibratedClassifierCV only works with predict_proba being float64
   
   To fix the latter, I'm now casting the output of predict_proba to
   float64. However, I'm not sure if this is a good idea, as it might break
   existing code. I'm just adding it in for now to check if the tests pass.

   

   BenjaminBossan committed Feb 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d022b23
   • Browse repository at this point

   Copy the full SHA

   d022b23 View commit details

   Browse the repository at this point in the history

2. Fix test after changing type of classes_

   

   BenjaminBossan committed Feb 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 43f5d3f
   • Browse repository at this point

   Copy the full SHA

   43f5d3f View commit details

   Browse the repository at this point in the history

3. Make CCCV test xfail for the time being

   

   BenjaminBossan committed Feb 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9a2e39b
   • Browse repository at this point

   Copy the full SHA

   9a2e39b View commit details

   Browse the repository at this point in the history

4. Set xfail non-strict bc test pass with old sklearn …

   For Python 3.8, an older sklearn version (1.3.2) is installed, which
   does not result in the test failing. Therefore, instead of requiring a
   strict xfail, make xfail optional.

   

   BenjaminBossan committed Feb 8, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for b64afda
   • Browse repository at this point

   Copy the full SHA

   b64afda View commit details

   Browse the repository at this point in the history