Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to work around WebSocketConnectionClosedException for slack #333

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

mattcl
Copy link
Contributor

@mattcl mattcl commented Feb 11, 2018

see slackapi/python-slack-sdk#118

This is an attempt to address #331

@mattcl mattcl mentioned this pull request Feb 12, 2018
@skoczen
Copy link
Owner

skoczen commented Feb 21, 2018

(Quick paste-on-all-open-issues update:)

TL;DR: New Will release EOM. Also, you're awesome.

Full Update: This may be TMI for you, and if so, cool, the thing you probably care about is above. But given the total radio silence on my part - and the fact that I've always tried to create a community here where we got to be actual people instead of avatars and PRs, I wanted to give a bit more context.

As you may be aware from an earlier AFK, I got married in December, which was great, but burned the month from a Will perspective. I planned to get back on it at the start of January, but instead found myself selling our house, and simultaneously hit with a surprisingly severe bout of depression. The time since Jan 1 has been sort of a blur. A dark blur, but a blur more than anything. I saw the PRs and comments coming in, but didn't have the energy or time to do anything about them.

Things seem to be clearing up on both counts now, and I'm really looking forward to getting these fixes in, catching up on bug reports, and being active in improving Will again. :)

With that, I'm aiming to get all outstanding PRs bundled into a release, and all issues replied to by the end of February.

Most of all, thanks for your contribution to Will, your patience with an imperfect, quite human project maintainer, and for continuing to come back, engage, and spend some of the precious seconds you get on earth making this project better.

I appreciate you. Thank you.

@skoczen
Copy link
Owner

skoczen commented Mar 19, 2018

@mattcl thanks so much for this fix, and welcome to the community!

I'll be merging this in and releasing it as 2.1.1 shortly - would you mind quickly adding the attribution you prefer to AUTHORS?

@skoczen
Copy link
Owner

skoczen commented Mar 21, 2018

Adding you without a name, just as mattcl, in the spirit of getting an important fix out sooner - please submit a PR with the attribution you prefer!

@skoczen skoczen merged commit 1498a6b into skoczen:master Mar 21, 2018
@skoczen
Copy link
Owner

skoczen commented Mar 22, 2018

This has been released in 2.1.1 - @mattcl thanks for the improvements, and do please submit a PR if you'd prefer different attribution!

Ashex pushed a commit that referenced this pull request Feb 5, 2022
Attempt to work around WebSocketConnectionClosedException for slack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants