This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: Conversion Aggregation Function #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 74.77% 74.94% +0.17%
==========================================
Files 132 134 +2
Lines 5371 5512 +141
==========================================
+ Hits 4016 4131 +115
- Misses 1016 1036 +20
- Partials 339 345 +6 ☔ View full report in Codecov by Sentry. |
davidterpay
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
aljo242
reviewed
Feb 6, 2024
aljo242
reviewed
Feb 6, 2024
aljo242
reviewed
Feb 6, 2024
| } | ||
| // CalculateMedian calculates the median from a list of big.Ints. Returns an | ||
| // average if the number of values is even. | ||
| func CalculateMedian(values []*big.Int) *big.Int { |
There was a problem hiding this comment.
should this live in pkg/math as well?
There was a problem hiding this comment.
Im fine keeping it in the other since it otherwise is going to duplicate testing, can add a test case to move at a later time.
aljo242
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes BLO-873