This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: Implement oracle_prices metric in PreBlock [BLO-790]
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivasan1
requested review from
davidterpay,
aljo242 and
Eric-Warehime
as code owners
nivasan1
commented
Jan 27, 2024
| // update price metric | ||
| o.metrics.UpdatePrice(provider.Name(), string(provider.Type()), pair.String(), float64(result.Value.Int64())) | ||
| o.metrics.UpdatePrice(provider.Name(), string(provider.Type()), pair.String(), floatValue) |
There was a problem hiding this comment.
context: I make this change as the .Int64() method on big.Int's behavior is undefined for non-int64 values, hence we can report incorrect information in the common-case
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 73.98% 74.01% +0.03%
==========================================
Files 131 125 -6
Lines 6776 6554 -222
==========================================
- Hits 5013 4851 -162
+ Misses 1434 1390 -44
+ Partials 329 313 -16 ☔ View full report in Codecov by Sentry. |
aljo242
approved these changes
Jan 29, 2024
nivasan1
force-pushed
the
nv/abci-message-size
branch
from
90833e6 to
b7db2c2
Compare
nivasan1
force-pushed
the
nv/oracle-report-metric
branch
2 times, most recently
from
e20e608 to
1871fed
Compare
nivasan1
force-pushed
the
nv/oracle-report-metric
branch
from
1871fed to
ac64596
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
oracle_pricesmetricbig.Intvalue reported as a float64 (in scientific notation, as opposed to an integer)