This repository was archived by the owner on Mar 24, 2025. It is now read-only.
chore: Fix dockerfile #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
requested review from
davidterpay,
nivasan1 and
aljo242
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 72.95% 72.89% -0.07%
==========================================
Files 117 117
Lines 6235 6235
==========================================
- Hits 4549 4545 -4
- Misses 1385 1389 +4
Partials 301 301 ☔ View full report in Codecov by Sentry. |
davidterpay
reviewed
Jan 26, 2024
config/local/oracle.toml
Outdated
| @@ -19,7 +19,7 @@ production = false | |||
| name = "" | |||
| read_buffer_size = 0 | |||
| write_buffer_size = 0 | |||
| handshake_timeout = "0s" | |||
There was a problem hiding this comment.
Not that this will be over-written any time the oracle is started as it refreshes the local config.
|
why is the handshake timeout affecting the API providers? Do you have any logs we can look at? |
davidterpay
approved these changes
Jan 26, 2024
False alarm--seems like it was just staleness. Dockerfile changes are all that's needed to get it running properly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the oracle sidecar in docker.