This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: huobi ws provider #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 73.72% 73.92% +0.19%
==========================================
Files 119 122 +3
Lines 6277 6404 +127
==========================================
+ Hits 4628 4734 +106
- Misses 1353 1368 +15
- Partials 296 302 +6 ☔ View full report in Codecov by Sentry. |
davidterpay
reviewed
Jan 26, 2024
Comment on lines
+73
to
+78
| reader, err := gzip.NewReader(bytes.NewReader(message)) | ||
| if err != nil { | ||
| h.logger.Error("error creating gzip reader", zap.Error(err)) | ||
| return resp, nil, err | ||
| } | ||
| defer reader.Close() |
There was a problem hiding this comment.
does the defer need to happen before the error?
There was a problem hiding this comment.
If there is an error, the reader that will be returned is nil
davidterpay
reviewed
Jan 26, 2024
davidterpay
approved these changes
Jan 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BLO-736