Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

feat: Instrument message-size for VoteExtensions + ExtendedCommit [BLO-794] #48

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

nivasan1
Copy link
Contributor

@nivasan1 nivasan1 commented Jan 26, 2024

In This PR

  • I introduce the oracle_message_size metric for VoteExtensions and for ExtendedCommits
  • This metric is reported on receipt of a VE in VerifyVoteExtensions and on receipt + verification of a proposed ExtendedCommit in ProcessProposal
  • This metric is implemented as a histogram
    • This let's us aggregate all observations (as opposed to a Gauge)
    • This also let's us calculate sample-wide statistics (which we couldn't do w/ a Gauge)
  • The buckets chosen are based off experimental observations from our prev. slinky load-tests, they are not final

@nivasan1 nivasan1 changed the title feat: Instrument message-size for VoteExtensions + ExtendedCommit feat: Instrument message-size for VoteExtensions + ExtendedCommit [BLO-794] Jan 26, 2024
@nivasan1 nivasan1 marked this pull request as ready for review January 26, 2024 20:58
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cee70a9) 73.94% compared to head (b7db2c2) 73.98%.

❗ Current head b7db2c2 differs from pull request most recent head 5f9b0b8. Consider uploading reports for the commit 5f9b0b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   73.94%   73.98%   +0.04%     
==========================================
  Files         131      125       -6     
  Lines        6766     6547     -219     
==========================================
- Hits         5003     4844     -159     
+ Misses       1434     1390      -44     
+ Partials      329      313      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nivasan1 nivasan1 force-pushed the nv/abci-method-status-pre-block branch from e0ff51a to 5275124 Compare January 26, 2024 23:13
@nivasan1 nivasan1 force-pushed the nv/abci-message-size branch from 0528a1a to 90833e6 Compare January 26, 2024 23:22
@nivasan1 nivasan1 changed the base branch from nv/abci-method-status-pre-block to main January 29, 2024 15:42
@nivasan1 nivasan1 force-pushed the nv/abci-message-size branch from 90833e6 to b7db2c2 Compare January 29, 2024 15:50
@nivasan1 nivasan1 merged commit 2a51da8 into main Jan 31, 2024
@zrbecker zrbecker deleted the nv/abci-message-size branch November 5, 2024 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants