This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: Add ABCIMethodLatency histogram [BLO-791]
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivasan1
requested review from
davidterpay,
aljo242 and
Eric-Warehime
as code owners
nivasan1
commented
Jan 22, 2024
| }), | ||
| Name: "abci_method_latency", | ||
| Help: "The time it took for an ABCI method to execute slinky specific logic (in seconds)", | ||
| Buckets: []float64{.0001, .0004, .002, .009, .02, .1, .65, 2, 6, 25}, |
There was a problem hiding this comment.
buckets chosen are in seconds, these are the same buckets used by cometBFTs, abci_method_latency histogram
nivasan1
force-pushed
the
nv/abci-method-latency
branch
from
d628a89 to
0fc81c7
Compare
nivasan1
commented
Jan 23, 2024
| @@ -77,7 +77,7 @@ func DefaultOracleConfig(node *cosmos.ChainNode) ( | |||
|
|
|||
| // Create the metrics config | |||
| metricsConfig := oracleconfig.MetricsConfig{ | |||
| PrometheusServerAddress: fmt.Sprintf("%s:%s", oracle.HostName(), "8081"), | |||
| PrometheusServerAddress: fmt.Sprintf("%s:%s", "0.0.0.0", "8081"), | |||
There was a problem hiding this comment.
expose app-metrics to docker-host, as opposed to oracle-host in docker-network
nivasan1
force-pushed
the
nv/abci-method-latency
branch
from
36e3ec6 to
68883c3
Compare
nivasan1
commented
Jan 23, 2024
| @@ -1,2 +1 @@ | |||
| go.work* | |||
There was a problem hiding this comment.
un ignore go.sum so dockerfiles can build
abci/proposals/proposals.go
Outdated
Comment on lines
273
to
286
| // record time spent in slinky-specific ProcesssProposal | ||
| processDuration := time.Since(start) | ||
|
|
||
| // call the wrapped process-proposal | ||
| resp, err := h.processProposalHandler(ctx, req) | ||
| if err == nil { | ||
| // record time spent in slinky-specific ProcesssProposal on successful process-proposals | ||
| h.logger.Info( | ||
| "recording process proposal time", | ||
| "duration (seconds)", processDuration.Seconds(), | ||
| ) | ||
| h.metrics.ObserveABCIMethodLatency(servicemetrics.ProcessProposal, processDuration) | ||
| } | ||
| return resp, err |
There was a problem hiding this comment.
The reason I had metrics observation in a defer was to guarantee that we reported a metric no matter what our response was.
The way you have it above will only report in the happy path and not any other result. I think we want to report metrics no matter whether the response is Accept or Reject.
There was a problem hiding this comment.
Ya, I intentionally wanted to only collect latencies for successful requests.
There was a problem hiding this comment.
You'd prefer to report in all cases?
nivasan1
force-pushed
the
nv/abci-method-latency
branch
from
68883c3 to
9294abc
Compare
nivasan1
force-pushed
the
nv/abci-method-latency
branch
from
19c2e36 to
26cf8ac
Compare
Eric-Warehime
approved these changes
Jan 23, 2024
Comment on lines
-60
to
+89
| // ObserveProcessProposalTime records the time it took for the oracle-specific parts of process proposal | ||
| ObserveProcessProposalTime(duration time.Duration) | ||
|
|
||
| // ObservePrepareProposalTime records the time it took for the oracle-specific parts of prepare proposal | ||
| ObservePrepareProposalTime(duration time.Duration) | ||
| // ObserveABCIMethodLatency reports the given latency (as a duration), for the given ABCIMethod, and updates the ABCIMethodLatency histogram w/ that value. | ||
| ObserveABCIMethodLatency(method ABCIMethod, duration time.Duration) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
ABCIMethodLatencyhistogram inservice/metrics/metrics.go, see the RFCREADMEsection for metrics, and a README forservice/metricsExample output