This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: create CurrencyPair type in new package
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2024 12:14
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/marketmap #110 +/- ##
==================================================
+ Coverage 74.87% 75.00% +0.12%
==================================================
Files 140 141 +1
Lines 5735 5764 +29
==================================================
+ Hits 4294 4323 +29
Misses 1088 1088
Partials 353 353 ☔ View full report in Codecov by Sentry. |
added 2 commits
February 9, 2024 14:55
Eric-Warehime
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CurrencyPairlogic and tests topkg/types