This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: Kraken WS Provider #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
|
misspelled word ! |
|
still need to add testing |
davidterpay
force-pushed
the
terpay/kraken
branch
from
6cee4b2 to
8711a45
Compare
davidterpay
commented
Jan 24, 2024
Comment on lines
+237
to
+286
| // TickerResponseMessage is the message that is sent to the client when the | ||
| // server has a price update for the subscribed asset pair. This is specific | ||
| // to the ticker subscription. | ||
| // | ||
| // [ | ||
| // 0, // ChannelID | ||
| // { | ||
| // "a": [ // Ask array | ||
| // "5525.40000", // Best ask price | ||
| // 1, // Whole lot volume | ||
| // "1.000" // Lot volume | ||
| // ], | ||
| // "b": [ // Bid array | ||
| // "5525.10000", // Best bid price | ||
| // 1, // Whole lot volume | ||
| // "1.000" // Lot volume | ||
| // ], | ||
| // "c": [ // Close array | ||
| // "5525.10000", // Price | ||
| // "0.00398963" // Lot volume | ||
| // ], | ||
| // "h": [ // High price array | ||
| // "5783.00000", // Today | ||
| // "5783.00000" // Last 24 hours | ||
| // ], | ||
| // "l": [ // Low price array | ||
| // "5505.00000", // Today | ||
| // "5505.00000" // Last 24 hours | ||
| // ], | ||
| // "o": [ // Open price array | ||
| // "5760.70000", // Today | ||
| // "5763.40000" // Last 24 hours | ||
| // ], | ||
| // "p": [ // Volume weighted average price array <- This is the value we want | ||
| // "5631.44067", // Value Today | ||
| // "5653.78939" // Value 24h | ||
| // ], | ||
| // "t": [ // Number of trades array | ||
| // 11493, // Today | ||
| // 16267 // Last 24 hours | ||
| // ], | ||
| // "v": [ // Volume array | ||
| // "2634.11501494", // Value Today | ||
| // "3591.17907851" // Value 24h | ||
| // ] | ||
| // }, | ||
| // "ticker", // Channel name | ||
| // "XBT/USD" // Asset pair | ||
| // | ||
| // ] |
There was a problem hiding this comment.
formatting is ok when look at github.dev not sure why it looks incorrect on the other.
There was a problem hiding this comment.
also looks fine when looking locally
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 72.69% 72.94% +0.24%
==========================================
Files 99 103 +4
Lines 5282 5445 +163
==========================================
+ Hits 3840 3972 +132
- Misses 1178 1198 +20
- Partials 264 275 +11 ☔ View full report in Codecov by Sentry. |
davidterpay
commented
Jan 24, 2024
Comment on lines
+17
to
+18
| // the handler should either return a response or a set of update messages. | ||
| HandleMessage(message []byte) (response providertypes.GetResponse[K, V], updateMessages []WebsocketEncodedMessage, err error) |
There was a problem hiding this comment.
adding this mostly for completeness with the other function signature
aljo242
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.