-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: do not check for expect before printing the argument of accept… #625
Conversation
@ibhagwan if you have some time, I'd love for you to take a very quick look at this and give me your opinion ! |
Will do some testing on master and let you know my thoughts, Ty @LoricAndre! |
I'll revert the change if you see anything, don't hesitate to tell me ! |
@LoricAndre, maybe I'm missing something but the below still doesn't work (the echo "1\n2" | sk --multi --bind=ctrl-q:select-all+accept --expect=ctrl-q |
Could you try |
I think we'll try to deprecate |
Good call, I find it confusing and counter intuitive and I like the |
The vim plugin uses --expect and expects the key used to accept the selection on the first line of output. Commit bcee1f4 "feat!: do not check for expect before printing the argument of accept… (skim-rs#625)" broke that by not outputting anything if the selection was made using the default "enter" key. We can workaround that by explicitly adding "enter" to the --expect argument, so that it once again shows up in the output.
The vim plugin uses --expect and expects the key used to accept the selection on the first line of output. Commit bcee1f4 "feat!: do not check for expect before printing the argument of accept… (skim-rs#625)" broke that by not outputting anything if the selection was made using the default "enter" key. We can workaround that by explicitly adding "enter" to the --expect argument, so that it once again shows up in the output. Fixes skim-rs/skim.vim#25
The vim plugin uses --expect and expects the key used to accept the selection on the first line of output. Commit bcee1f4 "feat!: do not check for expect before printing the argument of accept… (skim-rs#625)" broke that by not outputting anything if the selection was made using the default "enter" key. We can workaround that by explicitly adding "enter" to the --expect argument, so that it once again shows up in the output. Fixes skim-rs/skim.vim#25
The vim plugin uses --expect and expects the key used to accept the selection on the first line of output. Commit bcee1f4 "feat!: do not check for expect before printing the argument of accept… (#625)" broke that by not outputting anything if the selection was made using the default "enter" key. We can workaround that by explicitly adding "enter" to the --expect argument, so that it once again shows up in the output. Fixes skim-rs/skim.vim#25
…(...)
Checklist
check the box if it is not applicable to your changes
cargo xtask compgen
andcargo xtask mangen
Description of the changes
--expect
to be able to print the argument of theaccept
binding--expect
is set but a differentaccept
key is pressed--expect <key>
in favor of--bind:accept(<key>)
closes #624