Skip to content

Commit

Permalink
Remove /MP from common.gypi
Browse files Browse the repository at this point in the history
Forcing this option makes the option ```MultiProcessorCompilation``` in ```msvs_settings``` useless.  It also means that one cannot use ```#import``` or they will be faced with this error when trying to build:

```
error C2813: #import is not supported with /MP (compiling source file...)
```

Please see additional discussion of this here:  nodejs/node-gyp#1087
and here: nodejs/node-gyp#26
  • Loading branch information
skelliam authored Sep 2, 2018
1 parent e24fc95 commit ba29fde
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@
'BasicRuntimeChecks': 3, # /RTC1
'AdditionalOptions': [
'/bigobj', # prevent error C1128 in VS2015
'/MP', # compile across multiple CPUs
],
},
'VCLinkerTool': {
Expand Down

0 comments on commit ba29fde

Please sign in to comment.