Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Remove nested form from InputChips #2715

Merged
merged 5 commits into from
Jun 9, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Jun 7, 2024

Linked Issue

Closes #2711

Description

This replaces the nested form used to capture mobile Enter keys with a on:keyup event handler.

NOTE: this will need to be tested heavily in the world world before we can consider merging, as it has the potential to be a breaking change.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@endigo9740 endigo9740 linked an issue Jun 7, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 5:38pm
skeleton-next ❌ Failed (Inspect) Jun 8, 2024 5:38pm
skeleton-themes ❌ Failed (Inspect) Jun 8, 2024 5:38pm

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 66f7474

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@multiwebinc
Copy link

Are the changes to all the pnpm-lock files necessary for this PR?

@niktek
Copy link
Contributor

niktek commented Jun 8, 2024

Are the changes to all the pnpm-lock files necessary for this PR?

Could they have been in a separate PR, yes, but they aren't unexpected either as they are a result of updating to pnpm v9

@endigo9740
Copy link
Contributor Author

endigo9740 commented Jun 8, 2024

Yeah I work on multiple projects and recently needed to update PNPM for one of those. This was just a side effect.

Seems like things are working through, so I'll aim to merge this soon. It should be part of our next release. Thanks for bringing it to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte v5 RC: InputChip component produces errors
5 participants