-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Remove nested form from InputChips #2715
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 66f7474 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/skeleton/src/lib/components/InputChip/InputChip.svelte
Outdated
Show resolved
Hide resolved
packages/skeleton/src/lib/components/InputChip/InputChip.svelte
Outdated
Show resolved
Hide resolved
packages/skeleton/src/lib/components/InputChip/InputChip.svelte
Outdated
Show resolved
Hide resolved
packages/skeleton/src/lib/components/InputChip/InputChip.svelte
Outdated
Show resolved
Hide resolved
Are the changes to all the |
Could they have been in a separate PR, yes, but they aren't unexpected either as they are a result of updating to pnpm v9 |
Yeah I work on multiple projects and recently needed to update PNPM for one of those. This was just a side effect. Seems like things are working through, so I'll aim to merge this soon. It should be part of our next release. Thanks for bringing it to our attention. |
Linked Issue
Closes #2711
Description
This replaces the nested form used to capture mobile
Enter
keys with aon:keyup
event handler.NOTE: this will need to be tested heavily in the world world before we can consider merging, as it has the potential to be a breaking change.
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test