[Modal] убрать отображение фокуса на крестике при клике мышью #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lossir
requested changes
Oct 20, 2021
Comment on lines
-101
to
-103
| &:focus { | ||
| outline: 2px solid ${t.borderColorFocus}; | ||
| } |
There was a problem hiding this comment.
Чуть выше надо ещё удалить селектор &:focus,
There was a problem hiding this comment.
селектор удалила, но в класс focus из него перенесла свойство color, тк при фокусе цвет должен меняться
| const [focusedByTab, setFocusedByTab] = React.useState(false); | ||
|
|
||
| const handleFocus = () => { | ||
| if (!disableClose) { |
There was a problem hiding this comment.
Сейчас кнопка внешне не меняется, по факту попадает в фокус. Это уже другая ошибка, т.к. подобное поведение есть и сейчас, но давай поправим =)
Надо вместо этого условия добавить проп tabIndex={disableClose ? -1 : 0} в саму кнопку. Тогда она даже не будет попадать в фокус, соответственно не будет дергать событие onFocus.
lossir
approved these changes
Oct 21, 2021
zhzz
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2549
Реализовала через keyListener, как в остальных контролах.