Fixed copying of files

skaut · Oct 10, 2024 · 30e95bf · 30e95bf
1 parent b8e4654
commit 30e95bf
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/src/backend/utils/DriveBackedValue.ts b/src/backend/utils/DriveBackedValue.ts
@@ -45,7 +45,7 @@ export class DriveBackedValue_<T> {
 
   private getExistingDriveFileContents(fileId: string): T {
     return JSON.parse(
-      this.driveService.Files.get(fileId, null, { alt: "media" }) as string,
+      this.driveService.Files.get(fileId, null, { alt: "media" as const }),
     ) as T;
   }
 

diff --git a/src/backend/utils/SafeDriveService/SafeFilesCollection.ts b/src/backend/utils/SafeDriveService/SafeFilesCollection.ts
@@ -41,6 +41,15 @@ const safeFileKeys: DeepKeyof<SafeFile> = {
   },
 };
 
+interface GetArg {
+  alt?: string;
+}
+type GetReturn<F extends DeepKeyof<SafeFile>, A extends GetArg> = A extends {
+  alt: "media";
+}
+  ? string
+  : DeepPick<SafeFile, F>;
+
 export interface SafeFileList<F extends DeepKeyof<SafeFile>> {
   items: Array<DeepPick<SafeFile, F>>;
   nextPageToken?: string | undefined;
@@ -121,21 +130,24 @@ export class SafeFilesCollection_ {
     return ret;
   }
 
-  public get<F extends DeepKeyof<SafeFile>>(
+  public get<F extends DeepKeyof<SafeFile>, A extends GetArg>(
     fileId: string,
     fields: F | null,
-    optionalArgs: { alt?: string } = {},
-  ): DeepPick<SafeFile, F> {
+    optionalArgs: A = {} as A,
+  ): GetReturn<F, A> {
     const ret = this.unsafeFiles.get(fileId, {
       ...optionalArgs,
       ...(fields !== null && {
         fields: stringifyFields_(fields),
       }),
     });
-    if (!SafeFilesCollection_.fileIsSafe(ret, fields)) {
+    if (
+      typeof ret !== "string" &&
+      !SafeFilesCollection_.fileIsSafe(ret, fields)
+    ) {
       throw new Error("");
     }
-    return ret;
+    return ret as unknown as GetReturn<F, A>;
   }
 
   public insert<F extends DeepKeyof<SafeFile>>(