replace file constructors with context managers for python 3 compatibility #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htgoebel
suggested changes
May 26, 2017
vobject/change_tz.py
Outdated
| print("Done") | ||
| with open(out_name, 'wb') as out: | ||
| cal.serialize(out) | ||
| print("Done") |
There was a problem hiding this comment.
Arguable this line should not be part of the with block.
vobject/ics_diff.py
Outdated
| prettyDiff(cal1, cal2) | ||
| with open(ics_file1) as f, open(ics_file2) as g: | ||
| cal1 = readOne(f) | ||
| cal2 = readOne(g) |
There was a problem hiding this comment.
f and g are not used below, so the with-block should end here.
|
Any chance this will be released as 0.9.4.2 or 0.9.5? I saw that there are some milestones for the next releases but they are all done already. |
|
This will be released as part of 0.9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file()was removed in Python 3 - replace all calls withopen()and use with statements for closing. Resolves #66