Encode params if necessary in serialization #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While values are correctly encoded as utf8 if necessary, this conversion was missing for attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using vobject in calypso for managing my calendars. While importing my old ics files, I came across encoding errors in the
serializefunction. It turned out that while object values are encoded as utf8 if necessary, this was not done for parameters values.I fixed this and extended the tests to capture this problem. It would be great if you would consider merging this PR (I'll be happy to change things if necessary). Then I wouldn't need to patch vobject in my installation.
Thanks!
Matthias