Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortBy not persisted when a mod use the SortBuildsRemoteControlCommand #36

Closed
giacomelli opened this issue Sep 21, 2016 · 0 comments
Closed
Assignees
Labels

Comments

@giacomelli
Copy link
Member

When a mod uses the SortBuildsRemoteControlCommand the sort is right perform, but after the next builds refresh the previous sort by is reused.

This happens because when Buildron RC sends the same command it is intercepted by RemoteControlController.SendToServerSortBuilds method and the values are saved to ServerState:

m_serverState.BuildSortingAlgorithmType = sortingType;
m_serverState.BuildSortBy = sortByProperty;
m_serverService.SaveState(m_serverState);   

but when a mod use the sortBuildsRemoteControlCommand it is intercepted by SortingController.Start method and no ServerState is updated:

m_rcService.RemoteControlCommandReceived += (sender, e) => {
    var sortCmd = e.Command as SortBuildsRemoteControlCommand;  

    if(sortCmd != null)
    {
        OnBuildSortUpdated(new BuildSortUpdatedEventArgs(sortCmd.Algorithm, sortCmd.SortBy));
    }
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant